ArticlesProjectsCredentialsAbout

Code Review Guidelines (1997)

The written code review norms from the Motorola NMS team — what reviewers should look for, how to give feedback, and the criteria that block a change vs. suggestions.

code-reviewcollaborationquality

Code Review Guidelines (1997)

Written norms for code review — the document we gave every new team member and referred back to when reviews became unproductive.

Contents

  • review-checklist.md — what to look for: correctness, threading, resource cleanup, naming, tests
  • feedback-guidelines.md — how to frame comments: questions vs demands, blockers vs suggestions
  • review-log.csv — anonymised record of review outcomes (bug catch rate, cycle time) from 1997–98